Set language in Voice OTP TwiML #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 741e48e. **Why**: We want to use more advanced TwiML features like selecting language
zachmargolis
force-pushed
the
margolis-translate-voice-otp
branch
3 times, most recently
from
89be4fb to
e13aec1
Compare
**Why**: Updated code layout - Change basic auth to be a config value, not an ENV var - Set locale in voice OTP URLs - Set "language" attribute inside <Say> for better pronunciation
**Why**: URL params and GET params are in our logs, so this keeps plaintext codes out of our logs
zachmargolis
force-pushed
the
margolis-translate-voice-otp
branch
from
e2e145d to
395f69f
Compare
brodygov
reviewed
Oct 19, 2017
| repeat_count: repeat_count - 1 | ||
| ) | ||
| ) | ||
| end | ||
|
|
||
| def cipher | ||
| Gibberish::AES.new(Figaro.env.attribute_encryption_key) |
jmhooper
approved these changes
Oct 20, 2017
|
I opened a devops PR to add the basic auth username and password configs https://github.com/18F/identity-devops/pull/664. This needs to wait for that to be merged. |
|
I've added the secrets to dev. I'm going to deploy this there to try it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back old code to serve TwiML directly from our application, because this is the only way we can set the "language" attribute in
<Say>tagsAlso fixes:
NOTE: we'll want to make sure we deploy lower environments with a new config value for basic auth first
A lot of this is old code, updated because our app has changed a bit, so all the new stuff is in the second commit.