-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SVGs #1706
Update SVGs #1706
Conversation
I'm not sure if the P-key is right? The file names didn't match, but...maybe? |
@nickbristow can you explain this a little more? "I'm not sure if the P-key is right? The file names didn't match, but...maybe?" Can you provide some screenshots so I can take a look to see if it's the right illustration? |
@nickbristow I believe this new personal key illustration was for the public site (https://www.login.gov/security/) and it looks like the new images are already implemented there. Can you revert this illustration to the original one? If you're unsure of any of the others, drop in a screenshot here and I'll double check for you! |
7989dec
to
95b56c0
Compare
**Why**: To better match the overall style of the site
@mkhandekar yeah, the issue where this change was requested was not clear. I've updated the PR to remove the change to P-key |
Agreed! Thank you for the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is this good to merge?
@monfresh yes it is |
Why:
To better match the overall style of the site