Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SVGs #1706

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Update SVGs #1706

merged 1 commit into from
Oct 13, 2017

Conversation

nickbristow
Copy link
Contributor

Why:
To better match the overall style of the site

@nickbristow
Copy link
Contributor Author

I'm not sure if the P-key is right? The file names didn't match, but...maybe?

https://github.com/18F/identity-private/issues/2259

@mkhandekar
Copy link

@nickbristow can you explain this a little more? "I'm not sure if the P-key is right? The file names didn't match, but...maybe?" Can you provide some screenshots so I can take a look to see if it's the right illustration?

@nickbristow
Copy link
Contributor Author

update_svgs_by_nickbristow_ _pull_request__1706_ _18f_identity-idp

login_gov_-_just_in_case

@mkhandekar

@mkhandekar
Copy link

mkhandekar commented Oct 2, 2017

@nickbristow I believe this new personal key illustration was for the public site (https://www.login.gov/security/) and it looks like the new images are already implemented there. Can you revert this illustration to the original one?

If you're unsure of any of the others, drop in a screenshot here and I'll double check for you!

@nickbristow nickbristow force-pushed the update_illustrations branch from 7989dec to 95b56c0 Compare October 3, 2017 15:36
**Why**:
To better match the overall style of the site
@nickbristow
Copy link
Contributor Author

@mkhandekar yeah, the issue where this change was requested was not clear. I've updated the PR to remove the change to P-key

@mkhandekar
Copy link

Agreed! Thank you for the change.

Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this good to merge?

@nickbristow
Copy link
Contributor Author

@monfresh yes it is

@nickbristow nickbristow merged commit 500f3bf into master Oct 13, 2017
@nickbristow nickbristow deleted the update_illustrations branch October 13, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants