Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put newrelic config in source control #1699

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Conversation

zachmargolis
Copy link
Contributor

This is one commit on top of the previous S3 secrets branch: #1557

View just the incremental diff: margolis-s3-config-bootstrap...margolis-newrelic-config

@zachmargolis zachmargolis self-assigned this Sep 28, 2017
@brodygov brodygov changed the base branch from master to margolis-s3-config-bootstrap September 28, 2017 17:53
@brodygov
Copy link
Contributor

Changed the PR base to be margolis-s3-config-bootstrap

@zachmargolis zachmargolis changed the base branch from margolis-s3-config-bootstrap to master September 28, 2017 17:56
@zachmargolis
Copy link
Contributor Author

(changed the base back to master so we can deploy this separately)

@zachmargolis zachmargolis force-pushed the margolis-newrelic-config branch from 532afa5 to ea59f32 Compare September 28, 2017 18:05
**Why**: Easier to update locally
@zachmargolis zachmargolis force-pushed the margolis-newrelic-config branch from ea59f32 to ef81a2a Compare September 29, 2017 15:08
Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monfresh monfresh merged commit 2e14b4a into master Oct 13, 2017
@monfresh monfresh deleted the margolis-newrelic-config branch October 13, 2017 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants