Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter headers via Middleware #1663

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Filter headers via Middleware #1663

merged 1 commit into from
Sep 8, 2017

Conversation

zachmargolis
Copy link
Contributor

Why: The values are untrusted

Ideally we would not trust theHost header either, but I was not able to get that working

@zachmargolis
Filter headers via Middleware
ea4f619 
**Why**: The values are untrusted
@zachmargolis zachmargolis self-assigned this Sep 8, 2017
jmhooper
jmhooper approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@jmhooper jmhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does what we want it to

@zachmargolis zachmargolis merged commit 073261f into master Sep 8, 2017
@zachmargolis zachmargolis deleted the margolis-correct-host branch September 8, 2017 19:29
@zachmargolis zachmargolis mentioned this pull request Sep 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhooper jmhooper jmhooper approved these changes

@monfresh monfresh Awaiting requested review from monfresh

@brodygov brodygov Awaiting requested review from brodygov

Assignees

@zachmargolis zachmargolis

Labels
status - ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmargolis @jmhooper