Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove out-of-date documentation #1641

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Remove out-of-date documentation #1641

merged 1 commit into from
Aug 28, 2017

Conversation

zachmargolis
Copy link
Contributor

Why: Conflicts with current up-to-date information

--

@konklone pointed out these are out of date for misleading
cc @mzia @JohnRahaghi is there any reason to keep these?

**Why**: Conflicts with current up-to-date information
@@ -1 +0,0 @@
ssp_viewer:$apr1$/O6mfuN.$pct4cTe8r1j2B5RjM9mDZ1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this come from a private repo by mistake or something? Why were we keeping a basic auth username and (hashed) password in this repo to protect access to public contents?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't a mistake. It was there to build out the compliance masonry with gitpages and push out as a cloud.gov instance. I initially created with the hopes of using compliance masonry. These docs are super out of date and can be removed since we didn't go this route.

Copy link
Contributor

@konklone konklone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I left a question that would be worth answering anyway.

@zachmargolis
Copy link
Contributor Author

Thanks @mzia for confirming. Removing these.

@zachmargolis zachmargolis merged commit 73899db into master Aug 28, 2017
@zachmargolis zachmargolis deleted the margolis-remove-docs branch August 28, 2017 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants