Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NPM style guide package #1619

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Use NPM style guide package #1619

merged 1 commit into from
Aug 17, 2017

Conversation

hursey013
Copy link
Member

The change needed to make this function when the app is deployed to the various envs has been added, so resubmitting this reverted PR.

Here is the previous PR for reference:

This uses the identity-style-guide NPM package to import shared assets. This first PR imports relatively low risk assets: font files, and favicons. A follow up PR will address shared stylesheets, images, and possibly some Javascript.

@hursey013 hursey013 self-assigned this Aug 16, 2017
zachmargolis
zachmargolis approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hursey013 hursey013 requested a review from mugizico August 17, 2017 12:50
@hursey013 hursey013 merged commit 6710747 into master Aug 17, 2017
@hursey013 hursey013 deleted the bh-style-guide-again branch August 17, 2017 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis zachmargolis approved these changes

@mugizico mugizico Awaiting requested review from mugizico

Assignees

@hursey013 hursey013

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hursey013 @zachmargolis