Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gems with bummr #1594

Merged
merged 21 commits into from
Aug 8, 2017
Merged

Update gems with bummr #1594

merged 21 commits into from
Aug 8, 2017

Conversation

monfresh
Copy link
Contributor

@monfresh monfresh commented Aug 8, 2017

No description provided.

monfresh added 21 commits August 8, 2017 16:51
@monfresh
Update bummr from 0.1.8 to 0.2.1
10a4478
@monfresh
Update dotiw from 3.1.1 to 4.0.0
1779656
@monfresh
Update faker from 1.7.3 to 1.8.4
d5bb4e1
@monfresh
Update front_matter_parser from 0.1.0 to 0.1.1
8a98b37
@monfresh
Update hashie from 3.5.5 to 3.5.6
f6ee7dd
@monfresh
Update http_accept_language from 2.1.0 to 2.1.1
76026ad
@monfresh
Update httparty from 0.15.4 to 0.15.6
93ee23f
@monfresh
Update i18n-tasks from 0.9.15 to 0.9.16
0671294
@monfresh
Update lograge from 0.5.1 to 0.6.0
339b4be
@monfresh
Update newrelic_rpm from 4.2.0.334 to 4.3.0.335
f55ed27
@monfresh
Update overcommit from 0.39.1 to 0.40.0
f4f1ce4
@monfresh
Update phonelib from 0.6.12 to 0.6.13
926a8fd
@monfresh
Update poltergeist from 1.15.0 to 1.16.0
73b3618
@monfresh
Update premailer-rails from 1.9.6 to 1.9.7
3abc3ca
@monfresh
Update rails from 4.2.8 to 4.2.9
f3caafb
@monfresh
Update reek from 4.7.1 to 4.7.2
f1a05d7
@monfresh
Update savon from 2.11.1 to 2.11.2
7da7194
@monfresh
Update shoulda-matchers from 3.1.1 to 3.1.2
1fece21
@monfresh
Update sidekiq from 5.0.3 to 5.0.4
123ec18
@monfresh
Update timecop from 0.9.0 to 0.9.1
57f8535
@monfresh
Update zxcvbn-js from 4.4.2 to 4.4.3
1f2cbf8
zachmargolis
zachmargolis reviewed Aug 8, 2017
View reviewed changes
Gemfile.lock
nokogiri (~> 1.3)
zonebie (0.6.1)
zxcvbn-js (4.4.2)
zxcvbn-js (4.4.3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we bump the node package version to keep these in sync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Good catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's not available yet?

No compatible version found: zxcvbn@^4.4.3

Should I revert the gem until the node package is available?

Copy link
Contributor Author

@monfresh monfresh Aug 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Ruby gem's versioning does not necessarily correspond to the Dropbox versioning. It looks like he made a change to the Ruby code and updated the version number, so I think we're good to go here.
https://github.com/bitzesty/zxcvbn-js/commits/master

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah as long as it's still compatible with our patch to swap out the underlying JS, it's probably fine

👍

zachmargolis
zachmargolis approved these changes Aug 8, 2017
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monfresh
Copy link
Contributor Author

monfresh commented Aug 8, 2017

Thanks. Can you formally approve the PR please?

@monfresh
Copy link
Contributor Author

monfresh commented Aug 8, 2017

Never mind. I see it now.

@monfresh monfresh merged commit 2ccc3c8 into master Aug 8, 2017
@monfresh monfresh deleted the mb-update-gems branch August 8, 2017 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis zachmargolis approved these changes

@hursey013 hursey013 Awaiting requested review from hursey013

@gemfarmer gemfarmer Awaiting requested review from gemfarmer

@jmhooper jmhooper Awaiting requested review from jmhooper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monfresh @zachmargolis