Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit empty FormResponse errors from analytics logging #11799

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Jan 24, 2025

🛠 Summary of changes

Updates FormResponse#to_h to serialize an empty errors as nil instead of {}, effectively removing this value from logging.

This serves two purposes:

  • Reduce the size (and cost) of our logging payloads by removing values which aren't relevant for querying
  • Iterative step toward removing errors altogether.
    • These changes simplify future efforts by proactively removing assertions of errors: {}

📜 Testing Plan

Verify build passes.

Verify using make watch_events that any event which would have previously logged errors: {} will now exclude errors from the logging payload.

changelog: Internal, Analytics, Omit empty FormResponse errors from analytics logging
@aduth aduth force-pushed the aduth-errors-blank-omit branch from 76e90a9 to 8ed1f30 Compare January 27, 2025 13:10
@aduth aduth merged commit d32e350 into main Jan 27, 2025
2 checks passed
@aduth aduth deleted the aduth-errors-blank-omit branch January 27, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants