Create classes for tracking Attempts API events #11716
Open
+264
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Attempts API, Create class for tracking Attempts API events
zachmargolis
reviewed
Jan 7, 2025
zachmargolis
reviewed
Jan 7, 2025
app/services/attempts_api/tracker.rb
Outdated
| if metadata.has_key?(:failure_reason) && | ||
| (metadata[:failure_reason].blank? || | ||
| metadata[:success].present?) | ||
| metadata.delete(:failure_reason) |
There was a problem hiding this comment.
should we do metadata.dup so we're not mutating an input?
There was a problem hiding this comment.
I've replaced metadata.delete with using metadata.except which should have the same effect of creating a new hash.
zachmargolis
reviewed
Jan 7, 2025
mitchellhenke
force-pushed
the
mitchellhenke/attempts-api-tracker
branch
from
003640a to
031b693
Compare
Sgtpluck
approved these changes
Jan 22, 2025
mitchellhenke
force-pushed
the
mitchellhenke/attempts-api-tracker
branch
from
de27854 to
5d29b99
Compare
mitchellhenke
force-pushed
the
mitchellhenke/attempts-api-tracker
branch
from
5d29b99 to
3f86703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://gitlab.login.gov/lg-teams/Melba/protocols-backlog/-/issues/142
🛠 Summary of changes
A follow up to #11692 to create an interface to begin logging events to the previously implemented storage. This is also heavily based on the 2022 implementation with similar changes to accommodate multiple service providers. This PR creates an initial stub module for the list of events as well.