Update saml_idp gem to add support for AES-GCM encryption algorithms #11593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Upcoming Features, SAML, Update saml_idp gem to add support for AES-GCM encryption algorithms
zachmargolis
approved these changes
Dec 4, 2024
| @@ -85,7 +85,7 @@ gem 'valid_email', '>= 0.1.3', github: 'hallelujah/valid_email', ref: '486b860' | |||
| gem 'view_component', '~> 3.0' | |||
| gem 'webauthn', '~> 2.5.2' | |||
| gem 'xmldsig', '~> 0.6' | |||
| gem 'xmlenc', '~> 0.7', '>= 0.7.1' | |||
| gem 'xmlenc', '0.8.0' | |||
There was a problem hiding this comment.
should we keep the version that allows patch changes? This would allow 0.8.1 automatically I think
Suggested change
| gem 'xmlenc', '0.8.0' | |
| gem 'xmlenc', '~> 0.8' |
There was a problem hiding this comment.
It would, but the gem is very rarely updated and I'm not confident in version updates being safe without some more explicit checks 😅
There was a problem hiding this comment.
Coincidentally I'd tried that syntax earlier in #11590 (gem 'rubocop', '~> 1.69') hoping for the behavior you described, but it installed the outdated .0 version (1.69.0) instead of the latest version (1.69.1) 🤷
mitchellhenke
deleted the
mitchellhenke/update-saml-idp-to-support-gcm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Brings in the changes from 18F/saml_idp#129 to add IDP support for AES-GCM encryption of SAML responses. Other changes are required within our service provider configurations and partner portal, so it is not available quite yet, but allows for testing manually outside of those contexts.