Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return User UUID in requesting_issuer_uuid when generating user report #11553

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Do not return User UUID in requesting_issuer_uuid when generating user report #11553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/data_requests/deployed/create_user_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ def mfa_configurations_report
end

def requesting_issuer_uuid
return user.uuid if requesting_issuers.blank?
user.agency_identities.where(agency: requesting_agencies).first&.uuid ||
"NonSPUser##{user.id}"
end
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/data_requests/deployed/create_user_report_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

expect(result[:user_id]).to eq(user.id)
expect(result[:login_uuid]).to eq(user.uuid)
expect(result[:requesting_issuer_uuid]).to eq(user.uuid)
expect(result[:requesting_issuer_uuid]).to eq("NonSPUser##{user.id}")
expect(result[:email_addresses]).to be_a(Array)
expect(result[:mfa_configurations]).to be_a(Hash)
expect(result[:user_events]).to be_a(Array)
Expand Down