Update Data Request script to compute requesting issuer and have configurable depth #11541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igurable depth changelog: Internal, Scripts, Update DataRequest script to compute requesting issuer and have configurable depth
mitchellhenke
force-pushed
the
mitchellhenke/compute-requesting-issuer-in-data-request
branch
from
0a125b4 to
256b4e9
Compare
matthinz
reviewed
Nov 21, 2024
| return nil if service_providers.empty? | ||
| service_provider = service_providers.tally.max_by { |_sp, count| count }[0] | ||
|
|
||
| warn "Computed service provider #{service_provider}" |
There was a problem hiding this comment.
Maybe warn if there were UUIDs from multiple SPs detected?
zachmargolis
approved these changes
Nov 21, 2024
Co-authored-by: Zach Margolis <[email protected]>
Co-authored-by: Zach Margolis <[email protected]>
mitchellhenke
deleted the
mitchellhenke/compute-requesting-issuer-in-data-request
branch
AShukla-GSA
pushed a commit
that referenced
this pull request
Nov 25, 2024
…igurable depth (#11541) * Update Data Request script to compute requesting issuer and have configurable depth changelog: Internal, Scripts, Update DataRequest script to compute requesting issuer and have configurable depth * add log for multiple service providers * Update lib/data_pull.rb Co-authored-by: Zach Margolis <[email protected]> * Update lib/data_pull.rb Co-authored-by: Zach Margolis <[email protected]> --------- Co-authored-by: Zach Margolis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Following discussion yesterday here, this PR tries to address two potential improvements in the data request script:
ServiceProviderIdentity/AgencyIdentityUUIDs