Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary allowed_extra_analytics #11537

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Remove unnecessary allowed_extra_analytics #11537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions spec/features/openid_connect/openid_connect_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,9 +601,7 @@
to include('Verified within value must be at least 30 days or older')
end

it 'sends the user through idv again via verified_within param',
:js,
allowed_extra_analytics: [:*] do
it 'sends the user through idv again via verified_within param', :js do
client_id = 'urn:gov:gsa:openidconnect:sp:server'
allow(IdentityConfig.store).to receive(:allowed_verified_within_providers).
and_return([client_id])
Expand Down
10 changes: 3 additions & 7 deletions spec/features/saml/vtr_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,7 @@
expect_successful_saml_redirect
end

scenario 'sign in with VTR request for idv requires idv',
:js,
allowed_extra_analytics: [:*] do
scenario 'sign in with VTR request for idv requires idv', :js do
user = create(:user, :fully_registered)

visit_saml_authn_request_url(
Expand All @@ -150,8 +148,7 @@
expect_successful_saml_redirect
end

scenario 'sign in with VTR request for idv includes proofed attributes',
allowed_extra_analytics: [:*] do
scenario 'sign in with VTR request for idv includes proofed attributes' do
pii = {
first_name: 'Jonathan',
ssn: '900-66-6666',
Expand Down Expand Up @@ -190,8 +187,7 @@
end

scenario 'sign in with VTR request for idv with facial match requires idv with facial match',
:js,
allowed_extra_analytics: [:*] do
:js do
user = create(:user, :proofed)
user.active_profile.update!(idv_level: :legacy_unsupervised)

Expand Down
8 changes: 2 additions & 6 deletions spec/features/sign_in/multiple_vot_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@
expect(user_info[:vot]).to eq('C1.C2.P1')
end

scenario 'identity proofing with facial match is required if user is not proofed',
:js,
allowed_extra_analytics: [:*] do
scenario 'identity proofing with facial match is required if user is not proofed', :js do
user = create(:user, :fully_registered)

visit_idp_from_oidc_sp_with_vtr(vtr: ['C1.C2.P1.Pb', 'C1.C2.P1'])
Expand Down Expand Up @@ -176,9 +174,7 @@
expect(first_name).to_not be_blank
end

scenario 'identity proofing with facial match is required if user is not proofed',
:js,
allowed_extra_analytics: [:*] do
scenario 'identity proofing with facial match is required if user is not proofed', :js do
user = create(:user, :fully_registered)

visit_saml_authn_request_url(
Expand Down
4 changes: 1 addition & 3 deletions spec/features/users/user_profile_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,7 @@
expect(current_path).to eq(account_path)
end

it 'allows the user reactivate their profile by reverifying',
:js,
allowed_extra_analytics: [:*] do
it 'allows the user reactivate their profile by reverifying', :js do
profile = create(:profile, :active, :verified, pii: { ssn: '1234', dob: '1920-01-01' })
user = profile.user

Expand Down