Document analytics events properties to remove unnecessary allowed_extra_analytics #11536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Analytics, Document analytics event parameters
aduth
requested review from
a team,
jennyverdeyen and
solipet
and removed request for
a team
zachmargolis
approved these changes
Nov 20, 2024
solipet
approved these changes
Nov 20, 2024
eileen-nava
reviewed
Nov 22, 2024
| reprocess_delay_minutes: reprocess_delay_minutes, | ||
| enrollments_count:, | ||
| reprocess_delay_minutes:, | ||
| job_name:, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Documents a handful more analytics methods to remove
allowed_extra_analytics, toward eventual eradication of this metadata option.📜 Testing Plan
Verify build passes.
Spot check that required keyword arguments would be provided in all circumstances.