Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-15054: Remove GPO from IPP step indicator #11519

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

eileen-nava
Copy link
Contributor

@eileen-nava eileen-nava commented Nov 18, 2024

🎫 Ticket

LG-15054: Ensure that GPO steps cannot display in IPP step indicator

🛠 Summary of changes

  • Now that GPO has been removed from the IPP flow, there's no need to include GPO + IPP scenarios in the IPP step indicator.

📜 Testing Plan

Please manually test the IPP and GPO flow in order to ensure there are no regressions.
IPP

  • Log in via the identity-oidc sinatra app, select "default" as the Authentication Assurance Level (AAL) and "Identity-verified" as the Level of Service
  • Create an account and choose "verify your identity at a post office" for how to verify
  • You should see the below IPP step indicator.
Step Indicator:

IPPIndicator

GPO

  • Log in via the identity-oidc sinatra app, select "default" as the Authentication Assurance Level (AAL) and "Identity-verified" as the Level of Service
  • Create an account and choose the remote verification option
  • When you get to the page that confirms your phone number, enter (703)555-5555, which simulates a phone number that couldn’t be verified as belonging to the user
  • Select the "verify by mail" option
  • You should see the below GPO step indicator
Step Indicator:

GPOIndicatorMainBranch

@eileen-nava eileen-nava requested review from a team and WilliamBirdsall November 18, 2024 16:09
Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through the test plan and looked at the code changes. Everything looks good to me! 👍🏻

Copy link
Member

@jennyverdeyen jennyverdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the testing steps, both step indicators appear as expected. Code looks good to me!

@eileen-nava eileen-nava merged commit 76ab9f0 into main Nov 18, 2024
2 checks passed
@eileen-nava eileen-nava deleted the em/15054-remove-GPO-from-IPP-step-indicator branch November 18, 2024 18:20
@aduth aduth mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants