LG-12125: Do small cleanup while auditing tests for double address verification #11508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamBirdsall
approved these changes
Nov 14, 2024
|
FYSA: I can't merge this PR right now because I merged in main and it now has two failing specs, which are also failing on main. I will merge this PR after the build is fixed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12125: Audit and update unit test(s) for the entire ipp flow
🛠 Summary of changes
I put my notes in a comment in the jira ticket. I did review all unit tests for IPP, and found we had good coverage for double address verification. I made one follow-up ticket, LG-15054. This PR is mostly cleanup and small changes.
same_address_as_id📜 Testing Plan