Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14888: Update Spanish reCAPTCHA strings link text #11493

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Nov 12, 2024

🎫 Ticket

Follow-up revision for LG-14888 (originally implemented in #11448)

🛠 Summary of changes

Updates Spanish translations for reCAPTCHA disclaimer text to move "la" and "las" outside the link text, per feedback from translators.

📜 Testing Plan

Verify updated text for reCAPTCHA disclosure in Spanish:

Prerequisite: Configure real reCAPTCHA in local development. Any credentials work, they don't need to be valid:

# config/application.yml
development:
  recaptcha_site_key: 'test'
  recaptcha_enterprise_api_key: 'test'
  recaptcha_enterprise_project_id: 'test'
  recaptcha_mock_validator: false
  sign_in_recaptcha_score_threshold: 0.3
  sign_in_recaptcha_percent_tested: 100
  1. Go to http://localhost:3000/es/
  2. See updated translations

👀 Screenshots

Before After
Screenshot 2024-11-12 at 8 36 35 AM Screenshot 2024-11-12 at 8 40 51 AM

changelog: User-Facing Improvements, Localization, Improve Spanish translation for reCAPTCHA disclosure
@aduth aduth requested a review from a team November 12, 2024 13:41
@aduth aduth merged commit 5b17ca1 into main Nov 12, 2024
2 checks passed
@aduth aduth deleted the aduth-recaptcha-es-links branch November 12, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants