Set residentKey option for webauthn to preferred #11489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrajmohan
force-pushed
the
vm-webauthn-residentKey-preferred
branch
from
50cbf0e to
ebfddb0
Compare
aduth
reviewed
Nov 12, 2024
There was a problem hiding this comment.
This should only be configured for platform authenticators. The WebAuthn code is shared between Security Key (roaming authenticator) and Face or Touch Unlock (platform authenticator).
You can see an example of how to differentiate on the line preceding the new configuration (authenticatorAttachment)
vrajmohan
commented
Nov 12, 2024
| @@ -101,6 +101,7 @@ async function enrollWebauthnDevice({ | |||
| // contributes to abandonment or loss of access. | |||
| userVerification: 'discouraged', | |||
| authenticatorAttachment: platformAuthenticator ? 'platform' : 'cross-platform', | |||
| residentKey: platformAuthenticator ? 'preferred' : undefined, | |||
There was a problem hiding this comment.
IMO, this feels less opinionated than "discouraged".
aduth
approved these changes
Nov 12, 2024
See https://cm-jira.usa.gov/browse/LG-14911. It is expected that this will allow Android devices to create synced credentials using Google Password Manager, and for such devices to provide an AAGUID value. changelog: User-facing Improvements, F/T Unlock passkeys, Prefer residentKey for webauthn platform authenticators
vrajmohan
force-pushed
the
vm-webauthn-residentKey-preferred
branch
from
0b671c3 to
9db9245
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is expected that this will allow Android devices to create synced credentials using Google Password Manager, and for such devices to provide an AAGUID value.
changelog: User-facing Improvements, F/T Unlock passkeys, Set residentKey option for webauthn to preferred
🎫 Ticket
Link to the relevant ticket:
LG-14911
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
aaguidsaved in the tablewebauthn_configurations.