Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-14836 Update translations for IPP on doc auth error page #11483

Merged
merged 1 commit into from
Nov 12, 2024
Merged

LG-14836 Update translations for IPP on doc auth error page #11483

merged 1 commit into from
Nov 12, 2024

Conversation

shanechesnutt-ft
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-14386

🛠 Summary of changes

Update the translations for the IPP option on the doc auth error page.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Login through the oidc sinatra application selecting a non Enhanced In-person Proofing level of service.
  • Use an exisiting account or create an account
  • Continue through remote proofing flow until reaching the upload photos page
  • Upload a document that will fail
  • Verify the IPP translation on doc auth error page matches the AC of the story for all translations.

👀 Screenshots

Before:

English:

before_doc_auth_error_en

Spanish:

before_doc_auth_error_es

French:

before_doc_auth_error_fr

Chinese:

before_doc_auth_error_zh
After:

English:

after_doc_auth_error_en

Spanish:

after_doc_auth_error_es

French:

after_doc_auth_error_fr

Chinese:

after_doc_auth_error_zh

@shanechesnutt-ft shanechesnutt-ft requested review from a team, rutvigupta-design and jennyverdeyen and removed request for a team November 8, 2024 16:54
rutvigupta-design
rutvigupta-design approved these changes Nov 8, 2024
View reviewed changes
Copy link

@rutvigupta-design rutvigupta-design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 🎉 Once merged, I'll send to DOS for LQA! :)

WilliamBirdsall
WilliamBirdsall approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@WilliamBirdsall WilliamBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@shanechesnutt-ft
LG-14836 Update translations for IPP on doc auth error page
cedac76 
changelog: User-Facing Improvements, In-Person Proofing, Update the translations for the IPP option on the doc auth error page.
@shanechesnutt-ft shanechesnutt-ft merged commit f6f4d05 into main Nov 12, 2024
1 check passed
@shanechesnutt-ft shanechesnutt-ft deleted the sc/LG-14836 branch November 12, 2024 16:55
@jmdembe jmdembe mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rutvigupta-design rutvigupta-design rutvigupta-design approved these changes

@WilliamBirdsall WilliamBirdsall WilliamBirdsall approved these changes

@jennyverdeyen jennyverdeyen jennyverdeyen approved these changes

@aduth aduth aduth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shanechesnutt-ft @aduth @jennyverdeyen @WilliamBirdsall @rutvigupta-design