Jmax/lg 14008 handle redirect from socure in hybrid handoff #11473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmax-gsa
force-pushed
the
jmax/LG-14008-handle-redirect-from-socure-in-hybrid-handoff
branch
2 times, most recently
from
180eb6e to
633c4b4
Compare
jmax-gsa
requested review from
AShukla-GSA,
a team and
theabrad
and removed request for
a team
amirbey
reviewed
Nov 8, 2024
Comment on lines
53
to
62
| if result.success? | ||
| redirect_to idv_ssn_url | ||
| else | ||
| redirect_to idv_socure_document_capture_url | ||
| end |
There was a problem hiding this comment.
Suggested change
| if result.success? | |
| redirect_to idv_ssn_url | |
| else | |
| redirect_to idv_socure_document_capture_url | |
| end | |
| redirect_to idv_hybrid_mobile_socure_document_capture_url |
should we instead be redirecting to the hybrid mobile url here? ...
should be using this confirm_document_capture_needed filter? 🤔 ...
if so, can we move this filter in to a concern for use in both hybrid mobile document capture controllers?
There was a problem hiding this comment.
We do want to redirect to SSN on success, but you're right that we want to go back to hybrid mobile on failure. Changed.
jmax-gsa
force-pushed
the
jmax/LG-14008-handle-redirect-from-socure-in-hybrid-handoff
branch
from
41d9d23 to
ae5a3fe
Compare
When the user successfully verifies their identity using Socure in the hybrid flow, we redirect their computer session to the SSN entry step. changelog: Upcoming Features, Identity Verification, Handle Socure handoff. Co-authored-by: Douglas Price <[email protected]>
jmax-gsa
force-pushed
the
jmax/LG-14008-handle-redirect-from-socure-in-hybrid-handoff
branch
from
ae5a3fe to
3a83287
Compare
solipet
deleted the
jmax/LG-14008-handle-redirect-from-socure-in-hybrid-handoff
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-14008
After successful doc auth using Socure in the hybrid flow, the user continues to the 'Enter SSN' step.
🛠 Summary of changes
📜 Testing Plan
Requires a sandbox or other externally visible environment. Also requires the Socure webhook to be pointed at the testing environment. Currently deployed to jmax's sandbox. See jmax or Doug for help with this if needed.
/verify