-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-13006: remove all instances of skip_doc_auth and skipDocAuth - step 4.5 of 6 #11455
LG-13006: remove all instances of skip_doc_auth and skipDocAuth - step 4.5 of 6 #11455
Conversation
f371201
to
b56eadc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks go so far. I noticed that the app/services/idv/session.rb
and app/controllers/idv/socure/document_capture_controller.rb
still have skip_doc_auth
items have you looked at those? I wasn't sure if you meant to leave those in or not.
b56eadc
to
336a20c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me - I just see one remaining instance of skip_doc_auth in app/services/idv/session.rb
still, unless that is intentional!
@shanechesnutt-ft @jennyverdeyen thanks for the callouts, we actually have the removal of the variable from the session.rb as the next after the deployment in the ticket 👉 https://cm-jira.usa.gov/browse/LG-13006 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍🏻
🎫 Ticket
Link to the relevant ticket:
LG-13006
🛠 Summary of changes
This is one of the last steps a part of the parent ticket LG-13006 to remove the old
skip_doc_auth
variable after the newrenamed variable of
skip_doc_auth_from_how_to_verify
was introduced