lg-14790 handle network failures for socure

app/services/doc_auth/socure/request.rb

@@ -6,6 +6,9 @@ class Request
       def fetch
         # return DocAuth::Response with DocAuth::Error if workflow is invalid
         http_response = send_http_request
+        if http_response.nil? || !http_response.body.present?
+          return handle_invalid_response(http_response)
+        end
         return handle_invalid_response(http_response) unless http_response.success?
 
         handle_http_response(http_response)

app/services/doc_auth/socure/requests/document_request.rb

@@ -48,6 +48,11 @@ def handle_http_response(http_response)
         end
 
         def handle_invalid_response(http_response)
+          if http_response.nil? || !http_response.body.present?
+            message = [self.class.name, 'Unexpected HTTP response', 500].join(' ')
+            exception = DocAuth::RequestError.new(message, http_response.status)
+            return handle_connection_error(exception: exception)
+          end
           message = [
             self.class.name,
             'Unexpected HTTP response',

app/services/doc_auth/socure/requests/docv_result_request.rb

@@ -27,6 +27,31 @@ def handle_http_response(http_response)
           )
         end
 
+        def handle_invalid_response(http_response)
+          if http_response.nil? || !http_response.body.present?
+            message = [self.class.name, 'Unexpected HTTP response', 500].join(' ')
+            exception = DocAuth::RequestError.new(message, http_response.status)
+            return handle_connection_error(exception: exception)
+          end
+          message = [
+            self.class.name,
+            'Unexpected HTTP response',
+            http_response.status,
+          ].join(' ')
+          exception = DocAuth::RequestError.new(message, http_response.status)
+
+          response_body = begin
+            http_response.body.present? ? JSON.parse(http_response.body) : {}
+          rescue JSON::JSONError
+            {}
+          end
+          handle_connection_error(
+            exception: exception,
+            status: response_body.dig('status'),
+            status_message: response_body.dig('msg'),
+          )
+        end
+
         def handle_connection_error(exception:)
           NewRelic::Agent.notice_error(exception)
           DocAuth::Socure::Responses::DocvResultResponse.new(

app/services/doc_auth/socure/responses/docv_result_response.rb

@@ -110,7 +110,13 @@ def get_data(path)
         end
 
         def parsed_response_body
-          @parsed_response_body ||= JSON.parse(http_response.body).with_indifferent_access
+          @parsed_response_body ||= begin
+            http_response.body.present? ? JSON.parse(
+              http_response.body,
+            ).with_indifferent_access : {}
+          rescue JSON::JSONError
+            {}
+          end
         end
 
         def state_id_type

spec/controllers/idv/hybrid_mobile/socure/document_capture_controller_spec.rb

@@ -204,6 +204,14 @@
         get(:show)
         expect(response).not_to be_nil
       end
+      it 'socure nil response still gives a result to user' do
+        stub_request(:post, fake_socure_endpoint).to_return(
+          status: 500,
+          body: nil,
+        )
+        get(:show)
+        expect(response).not_to be_nil
+      end
     end
   end
 

spec/controllers/idv/socure/document_capture_controller_spec.rb

@@ -203,6 +203,14 @@
         get(:show)
         expect(response).not_to be_nil
       end
+      it 'socure nil response still gives a result to user' do
+        stub_request(:post, fake_socure_endpoint).to_return(
+          status: 500,
+          body: nil,
+        )
+        get(:show)
+        expect(response).not_to be_nil
+      end
     end
   end