lg-14790 handle network failures for socure

app/services/doc_auth/socure/request.rb

@@ -45,6 +45,10 @@ def handle_invalid_response(http_response)
         end
       end
 
+      def handle_connection_error
+        raise NotImplementedError
+      end
+
       def send_http_get_request
         faraday_connection.get do |req|
           req.options.context = { service_name: metric_name }

app/services/doc_auth/socure/requests/document_request.rb

@@ -47,6 +47,43 @@ def handle_http_response(http_response)
           JSON.parse(http_response.body, symbolize_names: true)
         end
 
+        def handle_invalid_response(http_response)
+          message = [
+            self.class.name,
+            'Unexpected HTTP response',
+            http_response.status,
+          ].join(' ')
+          exception = DocAuth::RequestError.new(message, http_response.status)
+
+          response_body = begin
+            http_response.body.present? ? JSON.parse(http_response.body) : {}
+          rescue JSON::JSONError
+            {}
+          end
+
+          handle_connection_error(
+            exception: exception,
+            status_code: response_body.dig('status', 'code'),
+            status_message: response_body.dig('status', 'message'),
+          )
+        end
+
+        def handle_connection_error(exception:, status_code: nil, status_message: nil)
+          NewRelic::Agent.notice_error(exception)
+          {
+            success: false,
+            errors: { network: true },
+            exception: exception,
+            extra: {
+              vendor: 'Socure',
+              selfie_live: false,
+              selfie_quality_good: false,
+              vendor_status_code: status_code,
+              vendor_status_message: status_message,
+            }.compact,
+          }
+        end
+
         def method
           :post
         end

app/services/doc_auth/socure/requests/docv_result_request.rb

@@ -27,6 +27,14 @@ def handle_http_response(http_response)
           )
         end
 
+        def handle_connection_error(exception:)
+          NewRelic::Agent.notice_error(exception)
+          DocAuth::Socure::Responses::DocvResultResponse.new(
+            http_response: nil,
+            biometric_comparison_required: @biometric_comparison_required,
+          )
+        end
+
         def document_capture_session
           @document_capture_session ||=
             DocumentCaptureSession.find_by!(uuid: document_capture_session_uuid)

spec/controllers/idv/hybrid_mobile/socure/document_capture_controller_spec.rb

@@ -82,6 +82,7 @@
       before do
         allow(I18n).to receive(:locale).and_return(expected_language)
         allow(request_class).to receive(:new).and_call_original
+        allow(request_class).to receive(:handle_connection_error).and_call_original
         get(:show)
       end
 
@@ -175,6 +176,20 @@
         expect(response).to be_not_found
       end
     end
+
+    context 'when socure connection error encountered' do
+      let(:fake_socure_endpoint) { 'https://fake-socure.com/' }
+      before do
+        allow(IdentityConfig.store).to receive(:socure_document_request_endpoint).
+          and_return(fake_socure_endpoint)
+        stub_request(:post, fake_socure_endpoint).to_raise(Faraday::ConnectionFailed)
+      end
+      it 'timeout still responds to user' do
+        get(:show)
+
+        expect(response).not_to be_nil
+      end
+    end
   end
 
   describe '#update' do

spec/controllers/idv/socure/document_capture_controller_spec.rb

@@ -175,6 +175,20 @@
         expect(response).to be_not_found
       end
     end
+
+    context 'when socure connection error encountered' do
+      let(:fake_socure_endpoint) { 'https://fake-socure.com/' }
+      before do
+        allow(IdentityConfig.store).to receive(:socure_document_request_endpoint).
+          and_return(fake_socure_endpoint)
+        stub_request(:post, fake_socure_endpoint).to_raise(Faraday::ConnectionFailed)
+      end
+      it 'timeout still responds to user' do
+        get(:show)
+
+        expect(response).not_to be_nil
+      end
+    end
   end
 
   describe '#update' do

spec/services/doc_auth/socure/requests/document_request_spec.rb

@@ -99,5 +99,33 @@
         expect { document_request.fetch }.not_to raise_error
       end
     end
+    context 'with timeout exception' do
+      let(:response) { nil }
+      let(:response_status) { 403 }
+      let(:faraday_connection_failed_exception) { Faraday::ConnectionFailed }
+
+      before do
+        stub_request(:post, fake_socure_endpoint).to_raise(faraday_connection_failed_exception)
+      end
+      it 'expect handle_connection_error method to be called' do
+        connection_error_attributes = {
+          success: false,
+          errors: { network: true },
+          exception: faraday_connection_failed_exception,
+          extra: {
+            vendor: 'Socure',
+            selfie_live: false,
+            selfie_quality_good: false,
+            vendor_status_code: nil,
+            vendor_status_message: nil,
+          }.compact,
+        }
+        result = document_request.fetch
+        expect(result[:success]).to eq(connection_error_attributes[:success])
+        expect(result[:errors]).to eq(connection_error_attributes[:errors])
+        expect(result[:exception]).to be_a Faraday::ConnectionFailed
+        expect(result[:extra]).to eq(connection_error_attributes[:extra])
+      end
+    end
   end
 end

spec/services/doc_auth/socure/requests/docv_result_request_spec.rb

@@ -0,0 +1,51 @@
+require 'rails_helper'
+
+RSpec.describe DocAuth::Socure::Requests::DocvResultRequest do
+  let(:document_capture_session_uuid) { 'fake uuid' }
+  let(:biometric_comparison_required) { false }
+
+  subject(:docv_result_request) do
+    described_class.new(
+      document_capture_session_uuid:,
+      biometric_comparison_required: biometric_comparison_required,
+    )
+  end
+
+  describe '#fetch' do
+    let(:fake_socure_endpoint) { 'https://fake-socure.com/' }
+    let(:fake_socure_api_endpoint) { 'https://fake-socure.com/api/3.0/EmailAuthScore' }
+    let(:docv_transaction_token) { 'fake docv transaction token' }
+    let(:user) { create(:user) }
+    let(:document_capture_session) do
+      DocumentCaptureSession.create(user:).tap do |dcs|
+        dcs.socure_docv_transaction_token = docv_transaction_token
+      end
+    end
+
+    before do
+      allow(IdentityConfig.store).to receive(:socure_idplus_base_url).
+        and_return(fake_socure_endpoint)
+      allow(DocumentCaptureSession).to receive(:find_by).and_return(document_capture_session)
+      stub_request(:post, fake_socure_api_endpoint).to_raise(Faraday::ConnectionFailed)
+    end
+
+    context 'with timeout exception' do
+      let(:fake_socure_response) { {} }
+      let(:fake_socure_status) { 500 }
+
+      it 'expect handle_connection_error method to be called' do
+        connection_error_attributes = {
+          http_response: nil,
+          biometric_comparison_required: biometric_comparison_required,
+        }
+        failed_response = DocAuth::Socure::Responses::DocvResultResponse.new(
+          **connection_error_attributes,
+        )
+        allow(DocAuth::Socure::Responses::DocvResultResponse).to receive(:new).
+          with(**connection_error_attributes).
+          and_return(failed_response)
+        expect(docv_result_request.fetch).to eq(failed_response)
+      end
+    end
+  end
+end