Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14548 Improve directory naming for table summary exports #11419

Merged
merged 2 commits into from
Oct 30, 2024
Merged

LG-14548 Improve directory naming for table summary exports #11419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2af4b3
LG-14548 Improve directory naming for table summary exports
colter-nattrass Oct 28, 2024
6e6794c
specs
colter-nattrass Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/jobs/data_warehouse/table_summary_stats_export_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

module DataWarehouse
class TableSummaryStatsExportJob < BaseJob
REPORT_NAME = 'idp_max_ids'
REPORT_NAME = 'table_summary_stats'

def perform(timestamp)
data = fetch_table_max_ids_and_counts(timestamp)
Expand Down
2 changes: 1 addition & 1 deletion spec/jobs/data_warehouse/table_summary_stats_export_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
context 'when uploading to S3' do
it 'uploads a file to S3 based on the report date' do
expect(job).to receive(:upload_file_to_s3_bucket).with(
path: 'idp_max_ids/2024/2024-10-10_idp_max_ids.json',
path: 'table_summary_stats/2024/2024-10-10_table_summary_stats.json',
**s3_metadata,
).exactly(1).time.and_call_original

Expand Down