Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14398: Add translations for "Email not yet selected" #11320

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Oct 7, 2024

🎫 Ticket

LG-14398

🛠 Summary of changes

Adds translations for the text "Email not yet selected".

This was implemented behind a feature flag in LG-13665 (#11196), but translations were not available for this particular string because it was not known to be needed until implementation had already started (see related Slack discussion), and the turnaround time for translations is long.

📜 Testing Plan

  1. Prerequisite: Have a connection with a service provider (documentation)
  2. Go to http://localhost:3000
  3. Sign in (if not already)
  4. From account dashboard, go to "Connected accounts"
  5. (If you see a selected email here, you'll need to destroy the association. In rails console, run User.find_with_email('<insert email address>').identities.update_all(email_address_id: nil) and reload the page)
  6. Note text "Email not yet selected"
  7. Change page language
  8. Note that the text for "Email not yet selected" is translated

👀 Screenshots

Language Before After
English Screenshot 2024-10-07 at 9 53 20 AM Screenshot 2024-10-07 at 9 53 20 AM
Spanish Screenshot 2024-10-07 at 9 54 29 AM Screenshot 2024-10-07 at 9 53 25 AM
French Screenshot 2024-10-07 at 9 54 25 AM Screenshot 2024-10-07 at 9 53 29 AM
Chinese Screenshot 2024-10-07 at 9 54 21 AM Screenshot 2024-10-07 at 9 53 33 AM

changelog: Upcoming Features, Partner Email Selection, Add translations for email not yet selected
@aduth aduth requested a review from a team October 7, 2024 14:11
@aduth aduth merged commit a1b84f8 into main Oct 7, 2024
2 checks passed
@aduth aduth deleted the aduth-lg-14398-translate-email-not-selected branch October 7, 2024 14:41
colter-nattrass pushed a commit that referenced this pull request Oct 23, 2024
changelog: Upcoming Features, Partner Email Selection, Add translations for email not yet selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants