Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14396 threat metrix create account device profiling #11278

Merged
merged 21 commits into from
Oct 4, 2024

Conversation

mdiarra3
Copy link
Contributor

@mdiarra3 mdiarra3 commented Sep 24, 2024

🎫 Ticket

Link to the relevant ticket:
LG-14396

🛠 Summary of changes

This adds device profiling for account creation, it leverages the same framework as for Proofing threat metrix profiling

📜 Testing Plan

Verify that when account_creation_device_profiling is set to enabled or collect_only the threatmetrix javascript appears on create your account page.

Example:

Screenshot 2024-09-26 at 12 01 33 PM

Copy link
Contributor

@matthinz matthinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a few comments

@mdiarra3 mdiarra3 marked this pull request as ready for review September 26, 2024 14:26
@mdiarra3 mdiarra3 changed the title Lg 14396 threat metrix create account LG-14396 threat metrix create account device profiling Sep 26, 2024
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
checked out locally and behaves as expected

@mdiarra3 mdiarra3 requested a review from matthinz September 27, 2024 13:48
Copy link
Contributor

@matthinz matthinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdiarra3 mdiarra3 merged commit d86199b into main Oct 4, 2024
2 checks passed
@mdiarra3 mdiarra3 deleted the LG-14396-threat-metrix-create-account branch October 4, 2024 13:32
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected to see some test coverage included here, e.g. for ThreatMetrixHelper, expected view rendering behavior for Tmx enabled, FeatureManagement#account_creation_device_profiling_collecting_enabled?.

colter-nattrass pushed a commit that referenced this pull request Oct 23, 2024
* Threat metrix initial page

* threat metrix helper

* changelog: Upcoming Features, Account creation, Threat metrix addiition

* fix up threatmetrix naming

* fix true

* fix up rubocop

* add override for csp for threat metrix

* fix linting

* update to move threatmetrix to idv

* add new line

* fix indentationg

* make threat metrix profiling into a separate partial

* fix styling indentation

* Threat metrix helper adjustment

* add regtistrations threat metrix spec

* fix ssn controller and spec

* update to use locals

* return empty hash

* remove unneeded spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants