-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-14396 threat metrix create account device profiling #11278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, left a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
checked out locally and behaves as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected to see some test coverage included here, e.g. for ThreatMetrixHelper
, expected view rendering behavior for Tmx enabled, FeatureManagement#account_creation_device_profiling_collecting_enabled?
.
* Threat metrix initial page * threat metrix helper * changelog: Upcoming Features, Account creation, Threat metrix addiition * fix up threatmetrix naming * fix true * fix up rubocop * add override for csp for threat metrix * fix linting * update to move threatmetrix to idv * add new line * fix indentationg * make threat metrix profiling into a separate partial * fix styling indentation * Threat metrix helper adjustment * add regtistrations threat metrix spec * fix ssn controller and spec * update to use locals * return empty hash * remove unneeded spec
🎫 Ticket
Link to the relevant ticket:
LG-14396
🛠 Summary of changes
This adds device profiling for account creation, it leverages the same framework as for Proofing threat metrix profiling
📜 Testing Plan
Verify that when
account_creation_device_profiling
is set to enabled or collect_only the threatmetrix javascript appears on create your account page.Example: