Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused analytics events #11215

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Sep 6, 2024

🛠 Summary of changes

Removes an unused analytics event method.

Discovered using a little bash script combined with manual review:

for i in `rails runner 'puts AnalyticsEvents.instance_methods.join(" ")'`
do
  if ! grep -q -R 'app' --exclude app/services/analytics_events.rb -e $i
  then
    echo $i;
  fi
done

The removed method was added in #10392 and its last reference removed in #10861.

📜 Testing Plan

Verify there are no code references to the removed method.

changelog: Internal, Analytics, Remove unused analytics events
@aduth aduth requested a review from mdiarra3 September 6, 2024 20:18
@aduth aduth merged commit 62cedd9 into main Sep 6, 2024
2 checks passed
@aduth aduth deleted the aduth-rm-unused-analytics-events branch September 6, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants