Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange connected accounts in stacked layout #11181

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Aug 30, 2024

🎫 Ticket

Supports LG-13665

🛠 Summary of changes

Updates the layout of the connected accounts page to show the content of individual accounts in a stacking arrangement, with a "Disconnect" button.

This incrementally works toward LG-13665, pending clarification about identities without linked emails.

It also includes a bit of general clean-up:

  • Avoid String#html_safe in favor of _html suffix for locale string
  • Use semantic HTML markup (headings for each item, <ul> for list of accounts)

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Sign in
  3. Click "Your connected accounts"
  4. Observe that accounts are rendered as shown in "After" screenshot

👀 Screenshots

Before After
image image

changelog: Upcoming Features, Partner Email Selection, Update layout arrangement for connected accounts
@aduth aduth requested a review from a team August 30, 2024 17:19
config/locales/en.yml Outdated Show resolved Hide resolved
@aduth aduth merged commit b56a9a6 into main Sep 3, 2024
2 checks passed
@aduth aduth deleted the aduth-lg-13665-connected-app-layout branch September 3, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants