Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return user to connected accounts when cancelling revocation #11178

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Aug 30, 2024

🛠 Summary of changes

Updates the connected accounts revocation screen to return a user to their connected accounts (where they came from) if they choose to cancel revocation, rather than the root accounts dashboard.

It also includes a handful of general code quality improvements:

  • Use standard PageFooterComponent
  • Update feature specs to interact with the page as a user would be expected to, rather than visiting URLs directly
  • Avoid redundant navigation in feature specs
  • Avoid redundant assertions (e.g. checking history path in revocation scenario, when already asserted in preceding scenario)

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Sign in
  3. From accounts dashboard, click "Your connected accounts"
  4. Click "Disconnect" on one of your connected accounts
    a. If you don't have a connected account, run and sign in through sample application
  5. When prompted to confirm revocation, click "Cancel"

Before: You'd be returned to the root account dashboard screen
After: You're returned to the "Your connected accounts" page (where you came from)

changelog: User-Facing Improvements, Connected Accounts, Return user to connected accounts when cancelling revocation
@aduth aduth requested a review from a team August 30, 2024 15:36
@aduth aduth merged commit 19a0d92 into main Aug 30, 2024
2 checks passed
@aduth aduth deleted the aduth-revoke-cancel-apps branch August 30, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants