LG-14196 | idv_consent_given -> idv_consent_given_at #11168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part 2, which moves everything over to using the new timestamp. Most things only care about the boolean state, so I added a method.
This is part 2, which moves everything over to using the new timestamp. Most things only care about the boolean state, so I added a method.
…y-idp into mattw/LG-14196_consent_part2
changelog: Internal, Socure, Replace idv_consent_given with timestamp
matthinz
reviewed
Aug 30, 2024
matthinz
reviewed
Sep 3, 2024
jmhooper
reviewed
Sep 5, 2024
| @@ -36,7 +36,6 @@ def update | |||
| ) | |||
|
|
|||
| if result.success? | |||
| idv_session.idv_consent_given = true | |||
There was a problem hiding this comment.
I think we need to keep these around for 1 more release cycle. Old instances will still be inspecting idv_session.idv_consent_given. We need to stop reading from these everywhere before we can stop writing it.
There was a problem hiding this comment.
Oh, good catch! The first PR started setting the timestamp, allowing this to begin reading it immediately, but I overlooked the inverse which will occur in the 50/50 state.
| @@ -296,6 +295,10 @@ def desktop_selfie_test_mode_enabled? | |||
| IdentityConfig.store.doc_auth_selfie_desktop_test_mode | |||
| end | |||
|
|
|||
| def idv_consent_given? | |||
There was a problem hiding this comment.
Smart to just make this a predicate method
matthinz
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14196
🛠 Summary of changes
<strikeDo not merge (at least, do not deploy) until after the previous PR for this story is released. (Done!)
This moves everything over to using
idv_consent_given_atvs. the old boolean. Since most stuff only cares about the boolean value, I added a lil' helper method.