Fix double personal key generation when using personal key as second …

…factor changelog: Bug Fixes, Personal Keys, Fix double personal key generation when using personal key as second factor
18F · Sep 12, 2024 · dd9c120 · dd9c120
1 parent d570405
commit dd9c120
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/app/controllers/two_factor_authentication/personal_key_verification_controller.rb b/app/controllers/two_factor_authentication/personal_key_verification_controller.rb
@@ -66,8 +66,7 @@ def alert_user_about_personal_key_sign_in(disavowal_token)
 
     def remove_personal_key
       # for now we will regenerate a key and not show it to them so retire personal key page shows
-      current_user.personal_key = PersonalKeyGenerator.new(current_user).create
-      current_user.save!
+      PersonalKeyGenerator.new(current_user).create
       user_session.delete(:personal_key)
     end