Skip to content

Commit

Permalink
Switched to "Continue" button (#1959)
Browse files Browse the repository at this point in the history
**Why**: Preference from designers.
  • Loading branch information
tbaxter-18f authored Feb 5, 2018
1 parent 038a88e commit adab037
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 11 deletions.
2 changes: 1 addition & 1 deletion app/views/shared/_user_verify_password.html.slim
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
= simple_form_for(current_user, url: update_path,
html: { autocomplete: 'off', method: :put, role: 'form' }) do |f|
= f.input :password, label: t('idv.form.password'), required: true
= f.button :submit, t('forms.buttons.submit.default'), class: 'btn btn-primary btn-wide'
= f.button :submit, t('forms.buttons.continue'), class: 'btn btn-primary btn-wide'
2 changes: 1 addition & 1 deletion spec/features/accessibility/idv_pages_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
fill_out_phone_form_ok(user.phone)
click_idv_continue
fill_in :user_password, with: Features::SessionHelper::VALID_PASSWORD
click_submit_default
click_continue

expect(current_path).to eq verify_confirmations_path
expect(page).to be_accessible
Expand Down
2 changes: 1 addition & 1 deletion spec/features/idv/flow_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
fill_out_phone_form_ok(user.phone)
click_idv_continue
fill_in :user_password, with: user_password
click_submit_default
click_continue

expect(current_url).to eq verify_confirmations_url
expect(page).to have_content(t('headings.personal_key'))
Expand Down
4 changes: 2 additions & 2 deletions spec/features/idv/phone_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

enter_correct_otp_code_for_user(user)
fill_in :user_password, with: user_password
click_submit_default
click_continue
click_acknowledge_personal_key

expect(current_path).to eq account_path
Expand Down Expand Up @@ -92,7 +92,7 @@
choose_idv_otp_delivery_method_sms
enter_correct_otp_code_for_user(user)
fill_in :user_password, with: user_password
click_submit_default
click_continue
click_acknowledge_personal_key

expect(current_path).to eq account_path
Expand Down
2 changes: 1 addition & 1 deletion spec/features/saml/loa3_sso_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def perform_id_verification_with_usps_without_confirming_code(user)
click_idv_address_choose_usps
click_on t('idv.buttons.mail.send')
fill_in :user_password, with: user.password
click_submit_default
click_continue
click_acknowledge_personal_key
click_link t('idv.buttons.continue_plain')
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,6 @@ def reactivate_profile(password, personal_key)
expect(current_path).to eq verify_password_path

fill_in 'Password', with: password
click_on t('forms.buttons.submit.default')
click_continue
end
end
2 changes: 1 addition & 1 deletion spec/support/features/idv_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def complete_idv_profile_ok(user, password = user_password)
fill_out_phone_form_ok(user.phone)
click_idv_continue
fill_in 'Password', with: password
click_submit_default
click_continue
end

def visit_idp_from_sp_with_loa3(sp)
Expand Down
4 changes: 4 additions & 0 deletions spec/support/features/session_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ def click_submit_default
click_button t('forms.buttons.submit.default')
end

def click_continue
click_button t('forms.buttons.continue')
end

def enter_correct_otp_code_for_user(user)
fill_in 'code', with: user.reload.direct_otp
click_submit_default
Expand Down
4 changes: 2 additions & 2 deletions spec/support/idv_examples/usps_verification_selection.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

fill_in :user_password, with: user_password

expect { click_submit_default }.
expect { click_continue }.
to change { UspsConfirmation.count }.from(0).to(1)

expect(current_path).to eq verify_confirmations_path
Expand Down Expand Up @@ -91,6 +91,6 @@ def complete_idv_profile_ok_with_usps
click_idv_address_choose_usps
click_on t('idv.buttons.mail.send')
fill_in :user_password, with: user_password
click_submit_default
click_continue
end
end
2 changes: 1 addition & 1 deletion spec/support/sp_auth_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def create_loa3_account_go_back_to_sp_and_sign_out(sp)
fill_out_phone_form_ok(user.phone)
click_idv_continue
fill_in :user_password, with: user.password
click_submit_default
click_continue
click_acknowledge_personal_key
expect(page).to have_current_path(sign_up_completed_path)
click_on t('forms.buttons.continue')
Expand Down

0 comments on commit adab037

Please sign in to comment.