Don't log extraneous event

If include_missing is specified and there are no missing users, don't log an event for them
18F · Oct 23, 2024 · 82097d8 · 82097d8
1 parent 04c76a1
commit 82097d8
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/lib/action_account.rb b/lib/action_account.rb
@@ -224,8 +224,10 @@ def run(args:, config:)
         )
       end
 
-      if config.include_missing?
-        (uuids - users.map(&:uuid)).each do |missing_uuid|
+      missing_uuids = (uuids - users.map(&:uuid))
+
+      if config.include_missing? && !missing_uuids.empty?
+        missing_uuids.each do |missing_uuid|
           table, messages = log_message(
             uuid: missing_uuid,
             log: log_text[:missing_uuid],
@@ -321,8 +323,9 @@ def run(args:, config:)
         )
       end
 
-      if config.include_missing?
-        (uuids - users.map(&:uuid)).each do |missing_uuid|
+      missing_uuids = (uuids - users.map(&:uuid))
+      if config.include_missing? && !missing_uuids.empty?
+        missing_uuids.each do |missing_uuid|
           table, messages = log_message(
             uuid: missing_uuid,
             log: log_text[:missing_uuid],