Merge pull request #1850 from 18F/jmhooper-remove-finance-step

Remove finance step from idv flow

.eslintrc

@@ -36,7 +36,6 @@
       'app/pw-toggle',
       'app/form-validation',
       'app/form-field-format',
-      'app/idv-finance-helper',
       'app/radio-btn',
       'app/print-personal-key',
       'app/utils/ms-formatter',

app/assets/javascripts/app/form-field-format.js

@@ -9,12 +9,8 @@ import ZipCodeFormatter from './modules/zip-code-formatter';
 
 function formatForm() {
   const formats = [
-    ['.auto_loan', new NumericFormatter()],
-    ['.ccn', new NumericFormatter()],
     ['.dob', new DateFormatter()],
-    ['.home_equity_line', new NumericFormatter()],
     ['.mfa', new NumericFormatter()],
-    ['.mortgage', new NumericFormatter()],
     ['.phone', new InternationalPhoneFormatter()],
     ['.us-phone', new USPhoneFormatter()],
     ['.personal-key', new PersonalKeyFormatter()],

app/assets/javascripts/application.js

@@ -3,7 +3,6 @@ import 'app/utils/index';
 import 'app/pw-toggle';
 import 'app/form-validation';
 import 'app/form-field-format';
-import 'app/idv-finance-helper';
 import 'app/radio-btn';
 import 'app/phone-internationalization';
 import 'app/print-personal-key';

app/assets/stylesheets/components/_form.scss

@@ -156,117 +156,3 @@ input::-webkit-inner-spin-button {
   background-color: $gray-light;
   border-color: $gray;
 }
-
-.select-alt {
-  color: $white;
-  display: inline-block;
-  position: relative;
-  width: 100%;
-
-  select {
-    -moz-appearance: none;
-    -webkit-appearance: none;
-    appearance: none;
-    background-color: $navy;
-    border-right: 1px solid $blue;
-    color: $white;
-    cursor: pointer;
-    display: inline-block;
-    font-weight: normal;
-    line-height: 1.5;
-    padding-right: 2.25rem;
-    width: 100%;
-  }
-
-  // Undo the Firefox inner focus ring
-  select:focus:-moz-focusring {
-    color: transparent;
-    text-shadow: 0 0 0 $white;
-  }
-
-  select:active {
-    background-color: $navy;
-    color: $white;
-  }
-
-  // Hide the arrow in IE10 and up
-  select::-ms-expand {
-    display: none;
-  }
-
-  // Separator
-  &::before {
-    border-right: 1px solid $blue;
-    content: '';
-    height: -moz-calc(3rem - 2px);
-    height: -webkit-calc(3rem - 2px);
-    height: calc(3rem - 2px);
-    position: absolute;
-    right: 3rem;
-    top: 1px;
-    width: 0;
-  }
-
-  // Dropdown arrow
-  &::after {
-    border-bottom: .35rem solid transparent;
-    border-left: .35rem solid transparent;
-    border-right: .35rem solid transparent;
-    border-top: .35rem solid;
-    content: '';
-    display: inline-block;
-    height: 0;
-    margin-top: -.15rem;
-    pointer-events: none;
-    position: absolute;
-    right: 1.25rem;
-    top: 50%;
-    width: 0;
-  }
-}
-
-// Media query to target Firefox only
-@-moz-document url-prefix() {
-  // Firefox hack to hide the arrow
-  .select-alt select {
-    padding-right: 1rem;
-    text-indent: .01px;
-    text-overflow: '';
-  }
-
-  // <option> elements inherit styles from <select>, so reset them.
-  .select-alt option {
-    background-color: $white;
-  }
-}
-
-// IE9 hack to hide the arrow
-@media screen and (min-width:0\0) {
-  .select-alt select {
-    padding: .5rem 1.5rem .5rem 1rem;
-    z-index: 1;
-  }
-
-  .select-alt::after {
-    z-index: 5;
-  }
-
-  .select-alt::before {
-    background-color: $navy;
-    bottom: 0;
-    content: '';
-    display: block;
-    position: absolute;
-    right: 1rem;
-    top: 0;
-    width: 1.5rem;
-    z-index: 2;
-  }
-
-  .select-alt select:hover,
-  .select-alt select:focus,
-  .select-alt select:active {
-    background-color: $navy;
-    color: $white;
-  }
-}

app/controllers/verify/review_controller.rb

@@ -9,7 +9,6 @@ class ReviewController < ApplicationController
 
     def confirm_idv_steps_complete
       return redirect_to(verify_session_url) unless idv_profile_complete?
-      return redirect_to(verify_finance_url) unless idv_finance_complete?
       return redirect_to(verify_address_url) unless idv_address_complete?
     end
 
@@ -69,10 +68,6 @@ def idv_profile_complete?
       idv_session.profile_confirmation == true
     end
 
-    def idv_finance_complete?
-      idv_session.financials_confirmation == true
-    end
-
     def idv_address_complete?
       idv_session.address_mechanism_chosen?
     end

app/controllers/verify/sessions_controller.rb

@@ -62,7 +62,7 @@ def step_name
     end
 
     def confirm_step_needed
-      redirect_to verify_finance_url if idv_session.profile_confirmation == true
+      redirect_to verify_address_url if idv_session.profile_confirmation == true
     end
 
     def step
@@ -87,7 +87,7 @@ def process_success
       flash[:success] = t('idv.messages.sessions.success',
                           pii_message: pii_msg)
 
-      redirect_to verify_finance_url
+      redirect_to verify_address_url
     end
 
     def process_failure