Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PW strength meter in uswds #78

Merged
merged 16 commits into from
Jun 5, 2019
Merged

PW strength meter in uswds #78

merged 16 commits into from
Jun 5, 2019

Conversation

lauraGgit
Copy link

No description provided.

@lauraGgit lauraGgit requested a review from donjo May 31, 2019 18:55
@lauraGgit lauraGgit changed the title WIP:pw strength meter in uswds PW strength meter in uswds May 31, 2019
@donjo
Copy link
Contributor

donjo commented Jun 3, 2019

Functionally LGTM but before merging I want to work on the visual design a bit, polishing the progress bars so they're full width and so the hint is italicized.

@donjo
Copy link
Contributor

donjo commented Jun 4, 2019

Screen Shot 2019-06-04 at 5 16 25 PM

Updated the styles but need to go back through and clean up the sass to ensure it's using the right variables and not just magic numbers everywhere.

@donjo donjo requested a review from achapm June 5, 2019 17:24
Copy link
Contributor

@achapm achapm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Javascript looks good

@lauraGgit lauraGgit merged commit 156812e into master Jun 5, 2019
@donjo donjo deleted the 2.0-password branch June 5, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants