Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Big variant of Dropdown component #330

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Add Big variant of Dropdown component #330

merged 2 commits into from
Jan 9, 2023

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 4, 2023 •
edited
Loading

@aduth aduth requested a review from nickttng January 4, 2023 19:22
zachmargolis
zachmargolis approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmargolis zachmargolis mentioned this pull request Jan 4, 2023
Merged
nickttng
nickttng approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 (Thank you!)

@aduth aduth merged commit 6fc3b4d into main Jan 9, 2023
@aduth aduth deleted the aduth-big-select branch January 9, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickttng nickttng nickttng approved these changes

@zachmargolis zachmargolis zachmargolis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduth @zachmargolis @nickttng