-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 7.0 breaking changes #298
Conversation
Other ideas:
|
It probably makes sense to release the next major version in tandem with USWDS v3, which is slated for release next month. |
8ff1c7c
to
16c0c78
Compare
I still like many of these ideas, but we can save them for a future major release. |
@zachmargolis I think I'd like to include these changes in the upcoming release. Could I tap you for a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(1) the width does not match the width of a paragraph in prose anyways (2) there's already a utility to achieve this effect
2d0e940
to
9a579f0
Compare
Visual regression failure is from the removal of the "Limiting Alert Width" documentation section, which is an expected breaking change. |
This is a staging area for breaking changes we'd like to implement in a future major version release.
Currently, it includes: