Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set font-size of tile checkbox/radio to 1.125rem #281

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 20, 2022

Why: To avoid font-face-specific sizing from causing the label text from being too small relative to the accompanying description.

Screenshots:

Before After
before after

Live preview URL: TBD

**Why**: To avoid font-face-specific sizing from causing the label text from being too small relative to the accompanying description.
Copy link
Contributor

@anniehirshman-gsa anniehirshman-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth
Copy link
Member Author

aduth commented Jan 24, 2022

Failing visual regression test is due to change in font size:

image

@aduth aduth merged commit c9f81a8 into main Jan 24, 2022
@aduth aduth deleted the aduth-tile-checkbox-explicit-font-size branch January 24, 2022 14:02
@aduth aduth mentioned this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants