Upgrade gulp-sass to v5, drop node-sass #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Because node-sass has proven to be tricky to manage across different Node versions. We already _also_ depend on the sass package, which can be assigned as the compiler implementation in the latest version of gulp-sass. This also reduces the overall number of dependencies of the project. Notably, the `sass` package is expected to be slower than `node-sass`, due to the fact that the latter compiles a C binary. In the future, we should look to migrate to the Dart version of the project, which is the currently maintained offering and offers similar performance to node-sass.
Match gulp-sass
clean-up, but fingers crossed maybe it could help build error? grasping at straws
Faster? According to docs: https://sass-lang.com/documentation/js-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Because node-sass has proven to be tricky to manage across different Node versions. We already also depend on the sass package, which can be assigned as the compiler implementation in the latest version of gulp-sass. This also reduces the overall number of dependencies of the project.
Changelog: https://github.com/dlmanning/gulp-sass/releases/tag/v5.0.0
Notably, the
sasspackage is expected to be slower thannode-sass, due to the fact that the latter compiles a C binary. In the future, we should look to migrate to the Dart version of the project, which is the currently maintained offering and offers similar performance to node-sass.