Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase padding and font size for tile checkbox #242

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

aduth
Copy link
Member

@aduth aduth commented Aug 25, 2021

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually, the padding looks a little too big to me? But if it matches the designs that's good enough for me 👍

@aduth
Copy link
Member Author

aduth commented Aug 25, 2021

Visually, the padding looks a little too big to me? But if it matches the designs that's good enough for me 👍

Yeah, there was some prior discussion about this on Slack. I'll defer to @anniehirshman-gsa or @cdelivuk on the final call, since maybe it makes a difference to see it "live". One thing I'll note is that it might appear a bit excessive in the examples only because there's not much supporting text, whereas in the real world we'll typically have a longer description.

For example:

image

Copy link
Contributor

@anniehirshman-gsa anniehirshman-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and yes, padding now matches design system Figma. I agree it's especially helpful to have when there is a larger block of text.

@aduth aduth merged commit eec75af into main Aug 27, 2021
@aduth aduth deleted the aduth-check-tile-padding branch August 27, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants