-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated research section from design.login.gov #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
In an effort to better communicate how the login.gov service communicates with third party providers and managers user data, the team created two different graphics to demonstrate how the login services work. We tested these two diagrams with a few users to see if they would be understandable to various stakeholders. | ||
|
||
![data flow model](/post-images/login--data-flow-model.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this file as well, since it's now unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 8899f2f
|
||
![data flow model](/post-images/login--data-flow-model.svg) | ||
|
||
![data flow model](/post-images/login--iam-model.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! 8899f2f
@@ -29,7 +29,3 @@ defaults: | |||
type: components | |||
values: | |||
sidenav: components | |||
- scope: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove lines 19 through 21 above, which still reference the research collection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done bfed82f
We have the |
@aduth thanks for the review + updates made ^5 Great question. Once we have a place to redirect them to we can implement this functionality. |
This pull request removes the
research
section from design.login.gov. While we do believe in sharing out our research publicly, we are re-assessing how we approach this in a more accessible way.