Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated research section from design.login.gov #226

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

juliaelman
Copy link
Member

This pull request removes the research section from design.login.gov. While we do believe in sharing out our research publicly, we are re-assessing how we approach this in a more accessible way.

@juliaelman juliaelman requested review from jmhooper and amoose July 7, 2021 16:14
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


In an effort to better communicate how the login.gov service communicates with third party providers and managers user data, the team created two different graphics to demonstrate how the login services work. We tested these two diagrams with a few users to see if they would be understandable to various stakeholders.

![data flow model](/post-images/login--data-flow-model.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this file as well, since it's now unused?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 8899f2f


![data flow model](/post-images/login--data-flow-model.svg)

![data flow model](/post-images/login--iam-model.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! 8899f2f

@@ -29,7 +29,3 @@ defaults:
type: components
values:
sidenav: components
- scope:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove lines 19 through 21 above, which still reference the research collection?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done bfed82f

@aduth
Copy link
Member

aduth commented Jul 7, 2021

We have the jekyll-redirect-plugin available. Depending whether we're worried about other sites linking to these pages, would there be somewhere else we could redirect them to?

@juliaelman
Copy link
Member Author

@aduth thanks for the review + updates made ^5

Great question. Once we have a place to redirect them to we can implement this functionality.

@juliaelman juliaelman merged commit 4bcdb88 into main Jul 7, 2021
@juliaelman juliaelman deleted the je-remove-outdated-research branch July 7, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants