Bump Jest timeout for SCSS compilation tests #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: So that the build doesn't fail by exceeding the default timeout of 5 seconds, where allowing the compilation to complete would otherwise succeed.
zachmargolis
approved these changes
May 25, 2021
| @@ -9,7 +9,7 @@ test('scss files can be imported without node_modules', async () => { | |||
| }); | |||
|
|
|||
| expect(results.css.toString('utf-8')).toMatch(/\.usa-/); | |||
| }); | |||
| }, 10000); | |||
There was a problem hiding this comment.
should we extract/name this as like assetTimeout?
There was a problem hiding this comment.
should we extract/name this as like
assetTimeout?
For me, this is one of those instance where I'd prefer to embrace the ugliness to avoid setting a precedent that this is acceptable, and to hopefully motivate some future proper resolution out of a discomfort in how we've chosen to implement this workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: So that the build doesn't fail by exceeding the default timeout of 5 seconds, where allowing the compilation to complete would otherwise succeed.
We should revisit the fact that this test is as slow as it is in the first place, possibly:
gulp-sasscompiler (usingnode-sassunder the hood) with Dart-based SASS (benchmarks, e.g. currently-experimentalsass-embedded)