Update .nvmrc to use latest LTS release #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: - Fix Federalist builds, which no longer support Node 10 - Avoid pinning to a specific version to reduce future maintenance overhead - Use a version of Node which hasn't fallen outside the maintenance calendar, to avoid missing critical bug fixes or encountering other conflicts See: https://nodejs.org/en/about/releases/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
See: https://nodejs.org/en/about/releases/
We may also want to consider bumping
enginesinpackage.json:https://github.com/18F/identity-style-guide/blob/9d919460b4c3cf03c24e5b7573348df7d3fdff1a/package.json#L53-L56
...but this means a different thing, as it prescribes the version of Node expected to be present in consuming projects. And since the IDP indirectly supports
>=12, it would be a mismatch to set this higher at>=14. And, strictly speaking, since the code is transpiled, it may be reasonable to expect that it runs in older versions.