Consolidate unstyled button font smoothing styles #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
force-pushed
the
aduth-unstyled-font-smoothing-3rd-times-a-charm
branch
from
803b3b6 to
13217e2
Compare
Merged
**Why**: - Account for missing `usa-button--unstyled:hover` and `usa-button--unstyled:active` - Single point to remove in the future, as noted in the preceding comment
aduth
force-pushed
the
aduth-unstyled-font-smoothing-3rd-times-a-charm
branch
from
13217e2 to
0d3d222
Compare
|
I think visual regression got confused with #214 since it runs against the live site, and the live site update was probably delayed around the latest rebase here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: 18F/identity-idp#4825 (comment)
Why:
usa-button--unstyled:hoverandusa-button--unstyled:active