Add custom components to LGDS #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
reviewed
Mar 26, 2021
src/scss/components/_sidenav.scss
Outdated
Comment on lines
43
to
47
| .sidenav { | ||
| ul { | ||
| border: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
In the .usa-sidenav styles above, we add a border style. If the expectation is that the LGDS sidenav has no border, could we remove it there?
There was a problem hiding this comment.
Yes. I will remove that border.
|
In the reference Figma, I see no border between the child elements of a side navigation. Should that be reflected here?
Edit: And also no background color on the current parent item, unless hovered? |
aduth
reviewed
Mar 29, 2021
Co-authored-by: Andrew Duthie <[email protected]>
Co-authored-by: Andrew Duthie <[email protected]>
Co-authored-by: Andrew Duthie <[email protected]>
jmdembe
force-pushed
the
jd-4405-custom-components
branch
from
46cf3a2 to
54c4b0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: