-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-4226: Document current button offerings ("big", "outline") #193
Conversation
<button class="usa-button usa-button--big"> | ||
``` | ||
|
||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The seemingly-unnecessary <div>
wrapper exists to prevent the button previews from being wrapped in <p>
, which in the context of the page .usa-prose
causes premature line wrapping.
It might make sense to apply this to all of the examples.
Edit: Now up-to-date. |
67385e7
to
8493781
Compare
8493781
to
f202b18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Couple tiny adjustments:
- All big button styles (except Unstyled buttons of course) should have .5rem/8px border radius
- For both regular and big Outline buttons: hover and active state text color should match the border color (hover =
primary-dark
, active =primary-darker
)
Per design See: #193 (review)
Inherit most styles from USWDS
Thanks @anniehirshman-gsa ! All good catches.
This is fixed in 6f7e3e1.
This is updated in 69a13a0. It appears that we were explicitly overriding this before. I just removed that, so the color should match the border. On closer inspection, there seemed to be quite a bit we were overriding from USWDS that was redundant, so as part of this, I was able to simplify the styles a decent amount. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great! 👍
This pull request...
Note: Between this and #191, whichever is merged first, the other should include and verify the behavior of the unstyled, big button. I tested this locally and it appeared to work reasonably well out of the box.
Screenshot:
Live Preview: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-lg-4226-document-outline-big/components/buttons/