Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README guidance for release process #188

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

aduth
Copy link
Member

@aduth aduth commented Feb 24, 2021

Why:

  • Changelog should be edited to replace "Unreleased" with the release version.
  • Main branch is protected, so you cannot commit the version bump directly. Improve text to include steps for creating a branch, opening a pull request, and merging before creating a new release.
  • Dry-run testing is all well and good, but there wasn't any guidance around what exactly one should be looking for in considering whether "everything looks alright". Add a couple tips on what to look for.

**Why**:

- Changelog should be edited to replace "Unreleased" with the release version.
- Main branch is protected, so you cannot commit the version bump directly. Improve text to include steps for creating a branch, opening a pull request, and merging before creating a new release.
- Dry-run testing is all well and good, but there wasn't any guidance around what exactly one should be looking for in considering whether "everything looks alright".
@aduth aduth requested a review from jmdembe February 24, 2021 20:59
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated
6. If everything looks alright, continue with publishing by running `npm publish`.
7. Create a new release on the [GitHub "Releases" page](https://github.com/18F/identity-style-guide/releases).
- Consider: In the files listed, are there any that should or shouldn't be included? Does the version match what you expect?
8. If everything looks alright, continue with publishing by running `npm publish`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a handbook page that links to a google doc that lists who has access to NPM to be able to publish, should we link to that from here?

https://handbook.login.gov/articles/accounts.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a handbook page that links to a google doc that lists who has access to NPM to be able to publish, should we link to that from here?

I shuffled this a bit in 39fc4e0 to include a leading "prerequisites" blurb of text:

Before starting, make sure that all changes intended for release should be merged into the main branch. You will need permissions to publish the package to npm. Check current package owners by running npm owner ls or by consulting the list of admins through the Services and Accounts handbook page. If you do not have access, contact an owner to have access granted or to publish on your behalf.

Copy link

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@aduth aduth merged commit d96515e into main Feb 25, 2021
@aduth aduth deleted the aduth-improve-release-guidance branch February 25, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants