Update favicon images to match (override) USWDS #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: So that we're publishing a consistent set of favicon icons, all of which use the Login.gov logo shield.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: 18F/identity-partners-site#17
Why: So that we're publishing a consistent set of favicon icons, all of which use the Login.gov logo shield.
See currently published images: https://unpkg.com/browse/[email protected]/dist/assets/img/favicons/
USWDS reference: https://github.com/uswds/uswds/tree/develop/src/img/favicons
favicon.png(USWDS)favicon.png(Login.gov)†favicon-16.png(USWDS)favicon-16.png(Login.gov)favicon-16x16.png(Login.gov)favicon-32x32.png(Login.gov)favicon-40.png(USWDS)favicon-40.png(Login.gov)favicon-57.png(USWDS)favicon-57.png(Login.gov)favicon-72.png(USWDS)favicon-72.png(Login.gov)favicon-114.png(USWDS)favicon-114.png(Login.gov)favicon-144.png(USWDS)favicon-144.png(Login.gov)favicon-192.png(USWDS)favicon-192.png(Login.gov)(† Note: Our
favicon.pngis 192 pixel size, vs. USWDS' 240. This is because I didn't have a large enough base copy of the favicon image. I don't know that the exact size matters as much, vs. being the largest available option)This also incidentally resolves an issue where the favicon appears as the USWDS logo when navigating design.login.gov in Firefox: