Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated USWDS v1 form hint class #634

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 14, 2023

Description of Changes:

Replaces .usa-form-hint with .usa-hint.

.usa-form-hint is a legacy class name from USWDS v1, replaced in USWDS v2 with .usa-hint (documentation).

We still define custom styles for this class in the Login.gov Design System (source), but I'd like to remove these styles, and this appears to the only instance in use I could find.

This does have a visual impact, but it is intended to bring into alignment with hints on other Login.gov sites. If needed, we could add additional utility classes to restore the original style.

Effective styles:

Before:

.usa-form-hint {
    padding-top: 0.25rem;
    padding-bottom: 0.25rem;
    display: inline-block;
}

After:

.usa-hint {
    color: #767676;
}

Screenshots:

Before After
localhost_3001_service_providers_new_ (1) localhost_3001_service_providers_new_

Why? For better future compatibility with the design system, and consistency across Login.gov products.
@aduth aduth requested a review from a team as a code owner April 14, 2023 19:00
@aduth aduth merged commit c2aea8c into main Apr 17, 2023
@aduth aduth deleted the aduth-update-form-hint-class branch April 17, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants