This repository has been archived by the owner on Nov 7, 2018. It is now read-only.
Fixing loading to account for Gunicorn's multiple instances #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing documentation
Closed
| echo "----- Loading Agency Contacts -----" | ||
| python manage.py load_agency_contacts | ||
| fi | ||
| waitress-serve --port=$VCAP_APP_PORT foia_hub.wsgi:application |
There was a problem hiding this comment.
Looks like this pull request doesn't just move the data loading and migrations to cf.sh. It also moves us from gunicorn to waitress. It's fine if that's your recommendation, but you should call that out. If we're going to move back to waitress, we're going to need to run a few more load tests and figure out our failover point.
There was a problem hiding this comment.
@khandelwal Actually, it should be gunicorn. I accidentally left it in after testing.
khandelwal
added a commit
that referenced
this pull request
May 4, 2015
Fixing loading to account for Gunicorn's multiple instances
|
Now that this is merged, I'm going to a do a deploy to staging, and check for errors in the logs. |
|
This looks good in staging. |
|
Also, looks like the 2014 times were updated correctly. |
|
@khandelwal has this been deployed to production? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved logic out of
wsgi.pytocf.sh